Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Deprecated no-reserved-keywords #674

Merged
merged 4 commits into from
Dec 14, 2018
Merged

Deprecated no-reserved-keywords #674

merged 4 commits into from
Dec 14, 2018

Conversation

JoshuaKGoldberg
Copy link

PR checklist

Overview of change:

Marks the rule as deprecated per #652.

JoshuaKGoldberg
JoshuaKGoldberg commented Dec 13, 2018
View reviewed changes
tslint-warnings.csv Outdated Show resolved Hide resolved
astorije
astorije approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, this arrives at the perfect time for us! :)
👍 on @IllusionMH's comment.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 14, 2018
Closed
@JoshuaKGoldberg JoshuaKGoldberg merged commit 112ca00 into microsoft:master Dec 14, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-reserved-keywords-deprecated branch December 14, 2018 17:10
@astorije
Copy link
Contributor

:shipit: :shipit: :shipit:

@JoshuaKGoldberg, are you planning on a release today? (Just to know if I temporarily tslint:disable in my code or not :D)

@JoshuaKGoldberg
Copy link
Author

:shipit: :shipit: :shipit:

Lol, forgot about that piece of history...

I wasn't planning on it, since this is the only user-facing change that goes in it. It's probably better to just disable no-reserved-keywords. Sorry!

@astorije
Copy link
Contributor

Not even worth a teeeeny tiny v6.0.1? 🙏😁
No worries if not.

@JoshuaKGoldberg
Copy link
Author

JoshuaKGoldberg commented Dec 14, 2018 •
edited
Loading

Haha sorry no, it'd be a patch-level breaking change.

@astorije
Copy link
Contributor

Really? I didn't realize it was a breaking change, I thought that was a simple deprecation for now.

@JoshuaKGoldberg
Copy link
Author

The added console.warn can be surprisingly confusing. I had a coworker new to the area completely disable TSLint locally because we'd bumped to a version and forgotten to disable no-unused-variables and they'd interpreted the warning as TSLint erroring out. It took us a little while to realize why they had so many "fix lint" commits in their PRs!

@astorije
Copy link
Contributor

That makes sense, thanks!

@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
@apawast
Deprecated no-reserved-keywords (microsoft#674)
efbccd0 
* Deprecated no-reserved-keywords

* Fixed silly copy & paste errors

* Fixed recommendation to be false

* Undid changes to tslint-warnings.csv
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IllusionMH IllusionMH IllusionMH left review comments

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging this pull request may close these issues.

Mark no-reserved-keywords as deprecated
3 participants
@JoshuaKGoldberg @astorije @IllusionMH